negames/SerializeReferenceExtensions-Better
26
0
Fork 0
forked from ThirdPartyPackagesMirrors/Unity-SerializeReferenceExtensions
Code Pull Requests Activity

Optimize drawing SubclassSelector

Browse Source
This commit is contained in:
mackysoft 2022-03-05 02:00:34 +09:00
parent a10a5b90e4
commit f8b317ba20
2 changed files with 19 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Assets/MackySoft/MackySoft.SerializeReferenceExtensions/Editor/ManagedReferenceUtility.cs
View File

@ -6,36 +6,18 @@ using UnityEditor;
namespace MackySoft.SerializeReferenceExtensions.Editor { namespace MackySoft.SerializeReferenceExtensions.Editor {
public static class ManagedReferenceUtility { public static class ManagedReferenceUtility {
public static Type GetManagedReferenceFieldType (this SerializedProperty property) {
if (property.propertyType != SerializedPropertyType.ManagedReference) {
throw SerializedPropertyTypeMustBeManagedReference(nameof(property));
}
return GetType(property.managedReferenceFieldTypename);
}
public static Type GetManagedReferenceType (this SerializedProperty property) {
if (property.propertyType != SerializedPropertyType.ManagedReference) {
throw SerializedPropertyTypeMustBeManagedReference(nameof(property));
}
return GetType(property.managedReferenceFullTypename);
}
public static object SetManagedReference (this SerializedProperty property,Type type) { public static object SetManagedReference (this SerializedProperty property,Type type) {
object obj = (type != null) ? Activator.CreateInstance(type) : null; object obj = (type != null) ? Activator.CreateInstance(type) : null;
property.managedReferenceValue = obj; property.managedReferenceValue = obj;
return obj; return obj;
} }
static Type GetType (string typeName) { public static Type GetType (string typeName) {
int splitIndex = typeName.IndexOf(' '); int splitIndex = typeName.IndexOf(' ');
var assembly = Assembly.Load(typeName.Substring(0,splitIndex)); var assembly = Assembly.Load(typeName.Substring(0,splitIndex));
return assembly.GetType(typeName.Substring(splitIndex + 1)); return assembly.GetType(typeName.Substring(splitIndex + 1));
} }
static ArgumentException SerializedPropertyTypeMustBeManagedReference (string paramName) {
return new ArgumentException("The serialized property type must be SerializedPropertyType.ManagedReference.",paramName);
}
} }
} }
#endif #endif

29
Assets/MackySoft/MackySoft.SerializeReferenceExtensions/Editor/SubclassSelectorDrawer.cs
View File

@ -5,6 +5,8 @@ using System.Collections.Generic;
using UnityEngine; using UnityEngine;
using UnityEditor; using UnityEditor;
using UnityEditor.IMGUI.Controls; using UnityEditor.IMGUI.Controls;
using UnityEngine.UIElements;
using UnityEditor.UIElements;
namespace MackySoft.SerializeReferenceExtensions.Editor { namespace MackySoft.SerializeReferenceExtensions.Editor {
@ -29,13 +31,11 @@ namespace MackySoft.SerializeReferenceExtensions.Editor {
readonly Dictionary<string,GUIContent> m_TypeNameCaches = new Dictionary<string,GUIContent>(); readonly Dictionary<string,GUIContent> m_TypeNameCaches = new Dictionary<string,GUIContent>();
SerializedProperty m_TargetProperty; SerializedProperty m_TargetProperty;
public override void OnGUI (Rect position,SerializedProperty property,GUIContent label) { public override void OnGUI (Rect position,SerializedProperty property,GUIContent label) {
EditorGUI.BeginProperty(position,label,property); EditorGUI.BeginProperty(position,label,property);
if (property.propertyType == SerializedPropertyType.ManagedReference) { if (property.propertyType == SerializedPropertyType.ManagedReference) {
TypePopupCache popup = GetTypePopup(property);
// Draw the subclass selector popup. // Draw the subclass selector popup.
Rect popupPosition = new Rect(position); Rect popupPosition = new Rect(position);
popupPosition.width -= EditorGUIUtility.labelWidth; popupPosition.width -= EditorGUIUtility.labelWidth;
@ -43,6 +43,7 @@ namespace MackySoft.SerializeReferenceExtensions.Editor {
popupPosition.height = EditorGUIUtility.singleLineHeight; popupPosition.height = EditorGUIUtility.singleLineHeight;
if (EditorGUI.DropdownButton(popupPosition,GetTypeName(property),FocusType.Keyboard)) { if (EditorGUI.DropdownButton(popupPosition,GetTypeName(property),FocusType.Keyboard)) {
TypePopupCache popup = GetTypePopup(property);
m_TargetProperty = property; m_TargetProperty = property;
popup.TypePopup.Show(popupPosition); popup.TypePopup.Show(popupPosition);
} }
@ -57,10 +58,13 @@ namespace MackySoft.SerializeReferenceExtensions.Editor {
} }
TypePopupCache GetTypePopup (SerializedProperty property) { TypePopupCache GetTypePopup (SerializedProperty property) {
if (!m_TypePopups.TryGetValue(property.managedReferenceFieldTypename,out TypePopupCache result)) { // Cache this string. This property internally call Assembly.GetName, which result in a large allocation.
var state = new AdvancedDropdownState(); string managedReferenceFieldTypename = property.managedReferenceFieldTypename;
Type baseType = property.GetManagedReferenceFieldType(); if (!m_TypePopups.TryGetValue(managedReferenceFieldTypename,out TypePopupCache result)) {
var state = new AdvancedDropdownState();
Type baseType = ManagedReferenceUtility.GetType(managedReferenceFieldTypename);
var popup = new AdvancedTypePopup( var popup = new AdvancedTypePopup(
TypeCache.GetTypesDerivedFrom(baseType).Where(p => TypeCache.GetTypesDerivedFrom(baseType).Where(p =>
(p.IsPublic || p.IsNestedPublic) && (p.IsPublic || p.IsNestedPublic) &&
@ -79,20 +83,23 @@ namespace MackySoft.SerializeReferenceExtensions.Editor {
m_TargetProperty.serializedObject.ApplyModifiedProperties(); m_TargetProperty.serializedObject.ApplyModifiedProperties();
}; };
m_TypePopups.Add(property.managedReferenceFieldTypename,new TypePopupCache(popup,state)); m_TypePopups.Add(managedReferenceFieldTypename,new TypePopupCache(popup,state));
} }
return result; return result;
} }
GUIContent GetTypeName (SerializedProperty property) { GUIContent GetTypeName (SerializedProperty property) {
if (string.IsNullOrEmpty(property.managedReferenceFullTypename)) { // Cache this string.
string managedReferenceFullTypename = property.managedReferenceFullTypename;
if (string.IsNullOrEmpty(managedReferenceFullTypename)) {
return k_NullDisplayName; return k_NullDisplayName;
} }
if (m_TypeNameCaches.TryGetValue(property.managedReferenceFullTypename,out GUIContent cachedTypeName)) { if (m_TypeNameCaches.TryGetValue(managedReferenceFullTypename,out GUIContent cachedTypeName)) {
return cachedTypeName; return cachedTypeName;
} }
Type type = property.GetManagedReferenceType(); Type type = ManagedReferenceUtility.GetType(managedReferenceFullTypename);
string typeName = null; string typeName = null;
AddTypeMenuAttribute typeMenu = TypeMenuUtility.GetAttribute(type); AddTypeMenuAttribute typeMenu = TypeMenuUtility.GetAttribute(type);
@ -108,7 +115,7 @@ namespace MackySoft.SerializeReferenceExtensions.Editor {
} }
GUIContent result = new GUIContent(typeName); GUIContent result = new GUIContent(typeName);
m_TypeNameCaches.Add(property.managedReferenceFullTypename,result); m_TypeNameCaches.Add(managedReferenceFullTypename,result);
return result; return result;
} }