better-ui-manager #2

Merged
BitterSmile merged 25 commits from better-ui-manager into main 2023-09-02 14:34:16 +02:00
Owner
No description provided.
BitterSmile added 9 commits 2023-05-20 01:59:04 +02:00
Niikelion was assigned by BitterSmile 2023-05-20 01:59:09 +02:00
mattusch.hubert added 1 commit 2023-05-20 20:03:31 +02:00
mattusch.hubert added 1 commit 2023-05-22 20:33:23 +02:00
BitterSmile added 1 commit 2023-05-27 21:39:33 +02:00
BitterSmile added 1 commit 2023-06-05 20:56:46 +02:00
BitterSmile added 1 commit 2023-06-09 01:01:52 +02:00
BitterSmile added 1 commit 2023-06-12 19:34:59 +02:00
BitterSmile added 1 commit 2023-06-30 13:41:50 +02:00
BitterSmile added 1 commit 2023-07-31 11:06:01 +02:00
Niikelion requested changes 2023-08-01 22:39:15 +02:00
Niikelion left a comment
Owner

Mainly unsused code to remove

Mainly unsused code to remove
@ -27,0 +32,4 @@
[SerializeField, Child(Flag.Optional)] private Image icon;
[SerializeField] private ButtonSettings groupButtonSettings;
//[SerializeField, Self(Flag.Optional)] private ButtonSettingOverride overrideSettings;
Owner

remove

remove
BitterSmile marked this conversation as resolved
@ -0,0 +8,4 @@
{
public SimpleSoundBehaviour(BaseButton baseButton, FmodSoundData data) : base(baseButton, data)
{
//TODO: use silnet to not play sound
Owner

?

?
Author
Owner

Will be added in another task

Will be added in another task
Niikelion marked this conversation as resolved
@ -0,0 +73,4 @@
{
style =
{
//
Owner

remove style if you are not setting any

remove style if you are not setting any
BitterSmile marked this conversation as resolved
@ -0,0 +28,4 @@
else
SetPointerInput();
//var keyboardAction = new InputAction(binding: "/<Keyboard>/*");
Owner

remove

remove
BitterSmile marked this conversation as resolved
@ -38,1 +43,3 @@
defaultPopupPrefab = prefabs[1].GetComponent<MonoDefaultPopup>();
var popupCanvas = Resources.Load<GameObject>("UI/PopupCanvas");
var defaultPopup = Resources.Load<GameObject>("UI/DefaultPopupPrefab");
//Addressables.LoadAssetsAsync<GameObject>(new List<string>() { "NEG/UI/PopupCanvas", "NEG/UI/DefaultPopupPrefab" }, (_) => { }, Addressables.MergeMode.Union).WaitForCompletion();
Owner

?

?
BitterSmile marked this conversation as resolved
BitterSmile added 2 commits 2023-08-12 11:15:15 +02:00
BitterSmile added 1 commit 2023-08-17 10:47:25 +02:00
Stawarska added 1 commit 2023-08-20 14:07:53 +02:00
Stawarska added 1 commit 2023-08-26 01:05:47 +02:00
BitterSmile added 1 commit 2023-09-01 21:42:43 +02:00
BitterSmile added 1 commit 2023-09-02 01:12:47 +02:00
Niikelion requested changes 2023-09-02 13:10:00 +02:00
@ -0,0 +11,4 @@
event Action<object> OnOpened;
event Action OnClosed;
event Action<BackUsed> UseBack;
Owner

this event is in different form than other, rename to OnBackUsed

this event is in different form than other, rename to `OnBackUsed`
BitterSmile marked this conversation as resolved
@ -0,0 +4,4 @@
{
public class SilentEventData : BaseEventData
{
public SilentEventData(EventSystem eventSystem) : base(eventSystem)
Owner

Why is this empty?

Why is this empty?
BitterSmile added 1 commit 2023-09-02 14:34:07 +02:00
BitterSmile merged commit d06350da06 into main 2023-09-02 14:34:16 +02:00
Sign in to join this conversation.
No Reviewers
No Label
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: negames/Neg_Utils#2
No description provided.