negames/Neg_Utils
26
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

achivments #1

Closed
Ghost wants to merge 13 commits from achivments into main
pull from: achivments
merge into: negames:main
Conversation 4 Commits 13 Files Changed 69 +2170
Ghost commented 2023-02-18 16:19:06 +01:00
First-time contributor
Copy Link

Achievment system

Achievment system
Ghost added 13 commits 2023-02-18 16:19:06 +01:00
Ghost requested review from Niikelion 2023-02-18 16:24:09 +01:00
Niikelion requested changes 2023-02-20 23:57:41 +01:00
Niikelion left a comment
Owner
Copy Link

Fix typos(Achievment -> Achievement)

Fix typos(`Achievment -> Achievement`)
BitterSmile requested changes 2023-02-21 00:14:50 +01:00
Achievments/AchievmentManager.cs
@ -0,0 +40,4 @@
foreach (var config in configs)
{
config.ApplyLast(builder);
BitterSmile commented 2023-02-21 00:01:18 +01:00
Owner
Copy Link

Why need this, when all are empty

Why need this, when all are empty
Ghost commented 2023-02-21 13:01:19 +01:00
Author
First-time contributor
Copy Link

was needed in earlier version, i will remove it

was needed in earlier version, i will remove it
Achievments/AchievmentManager.cs
@ -0,0 +58,4 @@
return this;
}
public Builder WithLabeledBackend(string label)
BitterSmile commented 2023-02-21 00:01:44 +01:00
Owner
Copy Link

no check for empty label

no check for empty label
Ghost commented 2023-02-21 13:06:55 +01:00
Author
First-time contributor
Copy Link

empty meaning null or empty meaning label with nothing assigned?

empty meaning null or empty meaning label with nothing assigned?
BitterSmile commented 2023-02-21 13:14:41 +01:00
Owner
Copy Link

you check for nothing, why even bother questioning

you check for nothing, why even bother questioning
Achievments/AchievmentsUpdater.cs
@ -0,0 +5,4 @@
namespace NEG.Utils.Achievments
{
public class AchievmentsUpdater : MonoBehaviour
BitterSmile commented 2023-02-21 00:14:41 +01:00
Owner
Copy Link

Should be created automaticly

Should be created automaticly
Ghost commented 2023-02-21 13:07:28 +01:00
Author
First-time contributor
Copy Link

How?

How?
BitterSmile commented 2023-02-21 13:15:17 +01:00
Owner
Copy Link

Create game object and add component?

Create game object and add component?
Ghost commented 2023-02-21 13:52:41 +01:00
Author
First-time contributor
Copy Link

When?

When?
BitterSmile commented 2023-02-21 21:50:16 +01:00
Owner
Copy Link

Duno it's your system

Duno it's your system
Achievments/Backend/SteamBackend/SteamBackendConfig.cs
@ -0,0 +31,4 @@
public SteamBackend()
{
//
SteamUserStats.RequestCurrentStats();
BitterSmile commented 2023-02-21 00:10:43 +01:00
Owner
Copy Link

No reaction for callback

No reaction for callback
Ghost commented 2023-02-21 13:08:36 +01:00
Author
First-time contributor
Copy Link

I asked about it, you said to ignore it, but I can change it

I asked about it, you said to ignore it, but I can change it
Achievments/Backend/SteamBackend/SteamBackendConfig.cs
@ -0,0 +47,4 @@
switch (achievment)
{
case IntAchievmentData intAchievment:
SteamUserStats.SetStat(id, intAchievment.CurrentProgress);
BitterSmile commented 2023-02-21 00:11:15 +01:00
Owner
Copy Link

No reaction for bool

No reaction for bool
Ghost commented 2023-02-21 13:09:01 +01:00
Author
First-time contributor
Copy Link

will fix

will fix
Achievments/Backend/SteamBackend/SteamBackendConfig.cs
@ -0,0 +104,4 @@
public void Update()
{
if (isDirty)
BitterSmile commented 2023-02-21 00:13:53 +01:00
Owner
Copy Link

Should be check when last time, min time of refresh sholub be greater than minute

Should be check when last time, min time of refresh sholub be greater than minute
Ghost commented 2023-02-21 13:09:48 +01:00
Author
First-time contributor
Copy Link

I dont understand

I dont understand
BitterSmile commented 2023-02-21 13:16:11 +01:00
Owner
Copy Link

look to documentatnion, you should fire storage callback withing minutes not seconds

look to documentatnion, you should fire storage callback withing minutes not seconds
Achievments/Backend/SteamBackend/SteamBackendConfig.cs
@ -0,0 +107,4 @@
if (isDirty)
{
//Reiterate on failure?
isDirty = !SteamUserStats.StoreStats();
BitterSmile commented 2023-02-21 00:13:19 +01:00
Owner
Copy Link

No reaction for callback

No reaction for callback
Ghost commented 2023-02-21 13:09:56 +01:00
Author
First-time contributor
Copy Link

will fix

will fix
BitterSmile commented 2023-02-21 00:15:23 +01:00
Owner
Copy Link

Just read steam api and use it with caution

Just read steam api and use it with caution
BitterSmile requested changes 2023-02-21 00:17:41 +01:00
Achievments/TODO.txt
@ -0,0 +1,5 @@
Static Achievments class (done)
BitterSmile commented 2023-02-21 00:17:38 +01:00
Owner
Copy Link

This file shouldn't exist

This file shouldn't exist
Ghost commented 2023-02-21 13:10:17 +01:00
Author
First-time contributor
Copy Link

will fix

will fix
BitterSmile closed this pull request 2023-05-21 12:58:25 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Niikelion
BitterSmile
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alloy AsiaTrzebu BartekKwiatkowski BitterSmile bob Carambola ComeReal Crosout darkcvffee Ewri fastfishdev Fiszeryk Grzybek jozzpoly Kravig mattusch.hubert Mintica mrgibek Natczek negamesback Niikelion Sihu Stawarska thefalconii velkarii Vestra2137
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: negames/Neg_Utils#1
No description provided.
Delete Branch "achivments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?